Re: log_min_messages per backend type

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: japin <japinli(at)hotmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Chao Li" <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: log_min_messages per backend type
Date: 2026-01-15 13:50:00
Message-ID: 603d4e3e-8aa1-485f-8f0c-3f48822fbf9c@app.fastmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 9, 2025, at 1:30 PM, Alvaro Herrera wrote:
> BTW another thing I realized while looking this over, is that we quite
> uselessly transform the integer backend type to a string, pass it as a
> string using the --forkchild= argument to the child process, then parse
> the string back to an int to use as an array index. It would be much
> easier to just use the integer value everywhere, as the attached shows.
>

It is a good simplification. There is just one oversight.

+ child_type = (BackendType) atoi(child_kind);
+ if (child_type <= B_INVALID || child_type > BACKEND_NUM_TYPES)
elog(ERROR, "unknown child kind %s", child_kind);

It should be BACKEND_NUM_TYPES - 1.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-01-15 13:51:52 Re: Add missing JIT inline pass for llvm>=17
Previous Message Ashutosh Bapat 2026-01-15 13:47:34 Re: Import Statistics in postgres_fdw before resorting to sampling.