| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alex Hunsaker <badalex(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: attoptions |
| Date: | 2010-01-21 02:51:32 |
| Message-ID: | 603c8f071001201851h19a88ec4n99291858fdf8ac5e@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 19, 2010 at 10:51 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
> But yes, lets keep it simple for now.
OK. Updated patch attached. Changes:
- Incorporate your previous review patch.
- Omit attacl and attoptions from hardcoded relation descriptor
initializers so the whole thing still builds.- Use
ATSimplePermissionsRelationOrIndex instead of custom permissions
logic.
- Remove recursion, per further thought about a comment in your
original review - I agree that the recursive behavior is weird.
- Remove a stray reference to SET STATISTICS DISTINCT in the documentation.
- Bug fix: this wasn't working at all for index-expression columns.
...Robert
| Attachment | Content-Type | Size |
|---|---|---|
| attoptions-v3.patch | text/x-patch | 44.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2010-01-21 02:54:54 | Re: Streaming Replication and archiving |
| Previous Message | Fujii Masao | 2010-01-21 02:42:03 | Re: HS/SR and smart shutdown |