| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
| Subject: | Re: lock_timeout GUC patch |
| Date: | 2010-01-20 15:42:11 |
| Message-ID: | 603c8f071001200742i112a1abx4d1aad831f0ed7a2@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2010/1/20 Boszormenyi Zoltan <zb(at)cybertec(dot)at>:
> Attached with the proposed modification to lift the portability concerns.
> Fixed the missing check for get_rel_name() and one typo ("transation")
> Introduced checks for semtimedop() and sem_timedwait() in configure.in
> and USE_LOCK_TIMEOUT in port.h depending on
> HAVE_DECL_SEMTIMEDOP || HAVE_DECL_SEM_TIMEDWAIT || WIN32
> Introduced assign_lock_timeout() GUC validator function that allows
> setting the value only from the wired-in-default (0) or from SET statements.
>
> Comments?
I think that it is a very bad idea to implement this feature in a way
that is not 100% portable.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-01-20 16:03:27 | Re: lock_timeout GUC patch |
| Previous Message | Gabriele Bartolini | 2010-01-20 15:38:04 | Re: MySQL-ism help patch for psql |