Re: Setting oom_adj on linux?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Alex Hunsaker <badalex(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Setting oom_adj on linux?
Date: 2010-01-08 17:37:11
Message-ID: 603c8f071001080937re102634wbea89c8424896d2@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 8, 2010 at 12:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>>> I don't want to go to the trouble of creating (and documenting) a
>>> configure option for this.  Much less a GUC ;-)
>
>> Requiring a custom build to disable it would be horrible, in my view.
>> Or, at best, just means that the packagers won't enable it, which
>> obviously would be less than ideal.
>
> I'm a packager, and I think that this approach is perfectly fine.
> The place where the rubber meets the road is in the init script,
> which is the packager's responsibility.  If the packager is going
> to provide an init script that sets oom_adj in the first place,
> he can turn on the compensation code inside the binary.  If not,
> the compensation code has no purpose anyhow.  There are no moving
> parts in this as far as the end user is concerned.

There could well be moving parts if the user wants to adjust the value
being written to oom_adj, and can't because it's compiled in. I don't
see why we can't just add a GUC for this and be done with it.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-01-08 17:38:50 Re: RFC: PostgreSQL Add-On Network
Previous Message Greg Stark 2010-01-08 17:35:23 Re: RFC: PostgreSQL Add-On Network