Re: Verifying variable names in pgbench

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Verifying variable names in pgbench
Date: 2010-01-05 03:33:47
Message-ID: 603c8f071001041933g152066cct7941721f9a498978@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 4, 2010 at 10:00 PM, Takahiro Itagaki
<itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>
> Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>
>> We can remove the complexity if we give up showing the command (arg0)
>> in error messages. Shall we remove it? Simplified patch attached.
>
> Here is the proposal for the arg0 issue.
> I added "context" argument to putVariable(). The context is a command
> name for \setXXX commands, 'option' for -D option, or 'startup' for
> internal assignment in startup.

What is currently done for other, similar error messages?

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-01-05 03:42:30 Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting
Previous Message Bruce Momjian 2010-01-05 03:30:09 Re: pg_migrator issues