| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: quoting psql varible as identifier |
| Date: | 2009-12-30 21:37:55 |
| Message-ID: | 603c8f070912301337o35e7bf9eh1e94b8e870f7ea57@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 29, 2009 at 3:19 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> here is patch
The error handling in quote_literal() doesn't look right to me. The
documentation for PQescapeStringConn says that it stores an error
message in the conn object, but your code ignores that and prints out
a generic message instead. That doesn't seem right: but then it
further goes on to call exit(1), which seems like a considerable
overreaction to an encoding violation, which is apparently the only
class of error PQescapeStringConn() is documented to throw.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-12-30 22:31:09 | Re: Thoughts on statistics for continuously advancing columns |
| Previous Message | Chris Browne | 2009-12-30 21:15:05 | Re: Thoughts on statistics for continuously advancing columns |