From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Largeobject Access Controls (r2460) |
Date: | 2009-12-19 03:05:47 |
Message-ID: | 603c8f070912181905w63c7cea0x76953413d1577f55@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 18, 2009 at 9:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Oh. This is more complicated than it appeared on the surface. It
>> seems that the string "BLOB COMMENTS" actually gets inserted into
>> custom dumps somewhere, so I'm not sure whether we can just change it.
>> Was this issue discussed at some point before this was committed?
>> Changing it would seem to require inserting some backward
>> compatibility code here. Another option would be to add a separate
>> section for "BLOB METADATA", and leave "BLOB COMMENTS" alone. Can
>> anyone comment on what the Right Thing To Do is here?
>
> The BLOB COMMENTS label is, or was, correct for what it contained.
> If this patch has usurped it to contain other things
It has.
> I would argue
> that that is seriously wrong. pg_dump already has a clear notion
> of how to handle ACLs for objects. ACLs for blobs ought to be
> made to fit into that structure, not dumped in some random place
> because that saved a few lines of code.
OK. Hopefully KaiGai or Takahiro can suggest a fix.
Thanks,
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-12-19 03:15:50 | Re: Largeobject Access Controls (r2460) |
Previous Message | suzhiyang | 2009-12-19 02:58:21 | About "Allow VIEW/RULE recompilation when the underlying tables change" |