Re: [PATCH] ACE Framework - Database, Schema

2009/12/13 KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>:
> The previous patch is too large to review.
> Is this scale confortable to review?

The scale is fine. But the content is not. So I am faced with a bit
of a dilemma. If I start enumerating specific reasons why it's not
OK, then it's going to take more time than I really want to put into
this project. If I don't, then I may be accused of hiding the ball.
What I'm hoping is that there are other interested people on this
mailing list (or not on this mailing list, maybe in the security
community) who have the time and the ability to help you fix some of
the issues here so that we can then have a serious design discussion.

Just to name a few really obvious problems (I only looked at the
01-database patch):

1. We have been talking for several days about the need to make the
initial patch in this area strictly a code cleanup patch. Is this
cleaner than the code that it is replacing? Is it even making an
attempt to conform to that mandate?

2. What will happen when someone runs pgindent against this?

Perhaps you only intended this to be a starting point for discussion,
in which case that's fine, but I don't think I can really contribute
anything useful until it gets a little further along.

Thanks,

...Robert