AFTER triggers & RETURN

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: AFTER triggers & RETURN
Date: 2009-11-05 21:34:59
Message-ID: 603c8f070911051334mc368e27me2dd5e086ea86a27@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom's recent work to fix the (TG_OP = 'INSERT' and NEW.foo ...)
problem reminded me of another PL/pgsql annoyance:

create table foo (a integer);
create or replace function broken() returns trigger as $$begin perform
1; end$$ language plpgsql;
create trigger bar after insert on foo for each row execute procedure broken();
insert into foo values (1);
ERROR: control reached end of trigger procedure without RETURN
CONTEXT: PL/pgSQL function "broken"

Since the return value is ignored anyway, why do we have to complain
if it's left out altogether? Granted, it's easy to work around, but
still.

...Robert

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2009-11-05 21:46:10 Re: AFTER triggers & RETURN
Previous Message Tom Lane 2009-11-05 21:33:07 Why do OLD and NEW have special internal names?