Re: Parsing config files in a directory

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Smith <gsmith(at)gregsmith(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parsing config files in a directory
Date: 2009-10-26 16:01:02
Message-ID: 603c8f070910260901l25dd5a7epa84db927426b4376@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 26, 2009 at 11:07 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Greg Smith <gsmith(at)gregsmith(dot)com> writes:
>> People who want to continue managing just the giant postgresql.conf are
>> free to collapse the initdb.conf back into the larger file instead.  If we
>> wanted to make that transition easier, an option to initdb saying "do
>> things the old way" might make sense.  I think the best we can do here is
>> make a path where new users who don't ask for anything special get a setup
>> that's easy for tools to work on, while not completely deprecating the old
>> approach for those who want it--but you have to ask for it.
>
> I don't think we need an explicit option for that.  What we need is an
> 'includedir' directive at the bottom of postgresql.conf.  Someone who
> prefers to let manual settings override anything else might choose to
> move it to the top, or even comment it out (at the cost of breaking
> SET PERSISTENT).  Everybody is happy, trogdolyte or otherwise.
>
> I would personally suggest having initdb dump its settings right into
> persistent.conf, rather than having a separate file for them, but it's
> not a big deal either way.

That make sense to me.

> (BTW, why do we actually need an includedir mechanism for this?
> A simple include of a persistent.conf file seems like it would be
> enough.)

I was starting to wonder that, too.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-10-26 16:06:35 Re: Endgame for all those SELECT FOR UPDATE changes: fix plan node order
Previous Message Tom Lane 2009-10-26 15:54:15 Re: Endgame for all those SELECT FOR UPDATE changes: fix plan node order