From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | "Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch: create or replace language |
Date: | 2009-10-06 14:30:45 |
Message-ID: | 603c8f070910060730oe9a761eo31bb36d1893d4d4e@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 6, 2009 at 10:24 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Andreas 'ads' Scherbaum wrote:
>>
>> Hello,
>>
>> following this old discussion:
>>
>> http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php
>>
>> i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax.
>> If the patch is ok, i will add the documentation too.
>
> Please send a context diff (however much ED IS THE STANDARD!!! TEXT
> EDITOR, we don't like its patches here). Note that you probably missed
> updates to other functions touching the node to which you add the
> boolean. Also, per Tom's followup,
>
>> Index: src/include/nodes/parsenodes.h
>> ===================================================================
>> RCS file: /projects/cvsroot/pgsql/src/include/nodes/parsenodes.h,v
>> retrieving revision 1.402
>> diff -r1.402 parsenodes.h
>> 1570a1571
>> > bool replace; /* T => replace if already exists */
>
> this comment needs fixed.
Maybe I'm out of line to say this, but it seems to me that we should
not even be looking at newly-submitted patches at this point.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-10-06 14:36:10 | Re: [PATCH] DefaultACLs |
Previous Message | Jaime Casanova | 2009-10-06 14:29:42 | Re: moving system catalogs to another tablespace |