| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Reworks for Access Control facilities (r2311) |
| Date: | 2009-09-29 13:41:58 |
| Message-ID: | 603c8f070909290641r62a5205ama3fbc98f98133fe0@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 29, 2009 at 6:54 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * KaiGai Kohei (kaigai(at)ak(dot)jp(dot)nec(dot)com) wrote:
>> Could you post any review comments, even if it is not comprehensive yet?
>
> In general, you don't need to preface your comments with 'MEMO:'. I
> would encourage removing that. You might use 'FIXME:' instead, if it is
> something which needs to be corrected in the future. Additionally,
> please think about PG as a whole project. Talking about 'native
> privilege mechanism' implies there are 'native' and 'foreign' ones. I
> would recommend using the term 'default' instead.
Or maybe 'standard'?
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-09-29 13:48:46 | Re: Rejecting weak passwords |
| Previous Message | Robert Haas | 2009-09-29 13:40:40 | Re: [PATCH] DefaultACLs |