Skip site navigation (1) Skip section navigation (2)

Re: Another patch

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Greg Stark <gsstark(at)mit(dot)edu>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: Another patch
Date: 2009-08-04 13:09:41
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-rrreviewers
On Tue, Aug 4, 2009 at 9:06 AM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Aug 4, 2009 at 7:23 AM, Greg Stark<gsstark(at)mit(dot)edu> wrote:
>> On Tue, Aug 4, 2009 at 2:28 AM, Jeff Davis<pgsql(at)j-davis(dot)com> wrote:
>>> On Mon, 2009-08-03 at 21:15 -0400, Robert Haas wrote:
>>>> On Sun, Aug 2, 2009 at 3:12 PM, Jeff Davis<pgsql(at)j-davis(dot)com> wrote:
>>>> > I'm ready for another patch. The prefix synonym patch is about done, I
>>>> > just made some doc/comment suggestions.
>>>> Thanks for all of your work so far.  Could you take a look at "Merge
>>>> Append"?  Tom already reviewed the planner parts of the patch, but I
>>>> think there are other things that could use some feedback.
>> For what it's worth the planner side of things was precisely the area
>> I needed feedback on. I'm not sure I know exactly what to do here but
>> I suppose Tom's done all he could and nobody else is going to be able
>> to help more. I'm happy with moving this to Returned with feedback.
> Well, in that case, never mind...


Given Greg's comments here, could you do an additional review of
"Parser's hook based on FuncCall"?



In response to


pgsql-rrreviewers by date

Next:From: Jeff DavisDate: 2009-08-09 17:31:26
Subject: Re: Another patch
Previous:From: Robert HaasDate: 2009-08-04 13:06:41
Subject: Re: Another patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group