Re: [PATCH] DefaultACLs

On Wed, Jul 22, 2009 at 11:26 PM, Petr Jelinek<pjmodos(at)pjmodos(dot)net> wrote:
> Robert Haas wrote:
>>
>> So are these warts fixed in the latest revision of this patch?
>>
>> http://archives.postgresql.org/pgsql-hackers/2009-07/msg01216.php
>>
>> I am gathering that this patch is still a bit of a WIP.  I think it
>> might be best to mark it returned with feedback and let Petr resubmit
>> for the next CommitFest when it is closer to being done.  But I don't
>> want to do that if it's really already to go now.
>>
>
> See http://archives.postgresql.org/pgsql-hackers/2009-07/msg01151.php (the
> revision before the one you pasted).

Ah, woops. Sorry I missed that. Actually, now that I read it, I
remember that I saw it before, but I didn't remember that before
sending my previous email, of course...

> The docs are not complete but that's up to Stephen, otherwise the patch
> should be finished. But I am not the reviewer :)

Well, perhaps we had better prod Stephen then, since complete docs are
a requirement for commit.

> Anyway, while this patch might not necessary get commited in this commit
> fest, I'd still like to have opinion from one of the commiters on "the VIEW
> problem" which also affects grant on all patch ( see
> http://archives.postgresql.org/pgsql-hackers/2009-07/msg00957.php ) and I
> fear "returned with feedback" might prevent that until next commit fest.

OK, hopefully one of them will chime in with an opinion. As I say, I
would like to see this get committed if it's done, I just wasn't sure
it was. But now it seems that was due to insufficiently careful
reading of the thread, with the exception of this issue and the need
to finish the docs.

Thanks,

...Robert