Re: [PATCH 3/3] Document geqo_seed variable.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH 3/3] Document geqo_seed variable.
Date: 2009-07-15 02:14:16
Message-ID: 603c8f070907141914u37ae4ac6r3fe8ca63b5e18fa0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 14, 2009 at 6:34 PM, Andres Freund<andres(at)anarazel(dot)de> wrote:
> ---
>  doc/src/sgml/config.sgml |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
> index 99d25d7..5d8eca9 100644
> *** a/doc/src/sgml/config.sgml
> --- b/doc/src/sgml/config.sgml
> *************** archive_command = 'copy "%p" "C:\\server
> *** 2150,2155 ****
> --- 2150,2171 ----
>        </listitem>
>       </varlistentry>
>
> +      <varlistentry id="guc-geqo-seed" xreflabel="geqo_seed">
> +       <term><varname>geqo_seed</varname>
> +       (<type>floating point</type>)</term>
> +       <indexterm>
> +        <primary><varname>geqo_seed</> configuration parameter</primary>
> +       </indexterm>
> +       <listitem>
> +        <para>
> +         Controls the initialization of the random number generator used
> +         by GEQO to select random paths through the join order search space.
> +         With the default setting of zero the join order planning is not repeatable.
> +         For repeatable planning set a value between 0 (exclusive) and 1 (inclusive).
> +        </para>
> +       </listitem>
> +      </varlistentry>
> +
>       </variablelist>
>      </sect2>
>       <sect2 id="runtime-config-query-other">
> --
> 1.6.3.3.335.ge09a8

I don't understand why people (including yourself, but you're not the
only one) have begun submitting relatively trivial patches in multiple
parts. This just creates multiple threads on the mailing list without
adding any value. The doc changes are part of the patch; one email
containing all the changes seems vastly preferable to me.

IMHO, the only reason for submitting multiple patches if it there are
pieces that are separately commitable.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-07-15 02:24:33 Re: navigation menu for documents
Previous Message Itagaki Takahiro 2009-07-15 02:12:21 Re: Sampling profiler updated