Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT
Date: 2009-05-05 02:13:31
Message-ID: 603c8f070905041913r667b3f32oa068d758ba5f17e1@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 3, 2009 at 11:14 PM, Jaime Casanova
<jcasanov(at)systemguards(dot)com(dot)ec> wrote:
> On Sun, May 3, 2009 at 3:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Apr 6, 2009 at 11:15 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> So based on this comment and Stephen's remarks, I'm going to assume
>>> that I'm succumbing to a fit of unjustified paranoia and re-implement
>>> as you suggest.
>>
>> OK, new version of patch, this time with the weird scaling removed and
>> the datatype changed to float4.
>
> In this paragraph i think you mean: "ALTER TABLE ... ALTER COLUMN ...
> SET DISTINCT"?

Ah, yes, so I do. Corrected patch attached.

> > I have not changed the minimum value for remoteVersion in pg_dump.c,
> > as that would make the patch not able to be tested now. So that line
> > and the comment two lines following will need to be updated prior to
> > application. Also requires catversion bump.

...Robert

Attachment Content-Type Size
ndistinct-3.patch text/x-diff 68.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Tolley 2009-05-05 02:41:45 Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT
Previous Message Hiroshi Saito 2009-05-05 02:02:10 Re: Unicode string literals versus the world