Re: [HACKERS] BUG #4516: FOUND variable does not work after RETURN QUERY

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-bugs(at)postgresql(dot)org, postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Subject: Re: [HACKERS] BUG #4516: FOUND variable does not work after RETURN QUERY
Date: 2009-02-04 19:44:51
Message-ID: 603c8f070902041144u4fa16584qf34e62c4f57aa69c@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Feb 4, 2009 at 1:32 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Robert Haas wrote:
>> > 2009/1/10 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> >> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> >>> Uh, is this ready to be applied?
>> >>
>> >> I don't think any consensus has been reached on changing this behavior.
>> >
>> > I thing, so this is bug - RETURN QUERY has to supply FOR SELECT LOOP
>> > RETURN NEXT pattern.
>> >
>> > My first patch expected so RETURN QUERY is final statement, so I don't
>> > solve FOUND variable, but Heikki changed this behave.
>> >
>> > Without correct FOUND behave we can't to use RETURN QUERY for following pattern
>> >
>> > RETURN QUERY some;
>> > IF FOUND THEN RETURN; END IF;
>> > RETURN QUERY some_other;
>> > RETURN;
>>
>> +1. I can't imagine it's good for this to be randomly inconsistent.
>
> So should this be applied or just kept for 8.5?

Well, *I* think it should be applied. But YMMV.

...Robert

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Dave Page 2009-02-04 20:31:06 Re: BUG #4635: postgres.exe crash when RAISE NOTICE during debugging of PL/pgSQL function in PgAdminIII
Previous Message Bruce Momjian 2009-02-04 18:32:47 Re: [HACKERS] BUG #4516: FOUND variable does not work after RETURN QUERY

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-02-04 19:52:40 Re: TODO items for window functions
Previous Message Robert Haas 2009-02-04 19:40:03 Re: [PATCHES] GIN improvements