Re: Restore enforce_generic_type_consistency's breaks a farms

From: "Robert Haas" <robertmhaas(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Zdenek Kotala" <Zdenek(dot)Kotala(at)sun(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Restore enforce_generic_type_consistency's breaks a farms
Date: 2008-12-15 17:01:30
Message-ID: 603c8f070812150901l332fe47cn3791095d68e62741@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 15, 2008 at 11:38 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> ... But this type of problem has come
>> up before. I wonder if we shouldn't do what was previously discussed:
>> make has_table_privilege and related functions silently return FALSE,
>> instead of throwing error, when given a "nonexistent" OID.
>
> On checking the archives, it seems most of the previous complaints have
> been about "cache lookup failed" errors arising from pg_table_is_visible
> and its ilk; those are used in the queries generated by psql's \d
> commands.
>
> So my proposal is to change the OID-accepting variants of
> has_table_privilege and friends, as well as pg_table_is_visible and
> friends, to silently return FALSE instead of failing when given a
> bad OID. I had originally thought we might change the underlying

Or maybe NULL?

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2008-12-15 17:03:41 Re: Block-level CRC checks
Previous Message Alvaro Herrera 2008-12-15 16:50:48 Re: Block-level CRC checks