Re: Updated posix fadvise patch v19

From: "Robert Haas" <robertmhaas(at)gmail(dot)com>
To: "Gregory Stark" <stark(at)enterprisedb(dot)com>
Cc: Postgres <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Updated posix fadvise patch v19
Date: 2008-11-19 04:01:11
Message-ID: 603c8f070811182001r3870122ep3f4ff69c1c93ef30@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Obviously that went too soon.

> In config.sgml, the documentation is good, but suffers from a slightly
> informal style. There are a lot of places where commas seem
> appropriate but are not present. Suggested changes by paragraph:
>
> 1. Replace last sentence: "Raising this value will cause PostgreSQL to initiate

...more I/O operations in parallel."

2. "Typically, this parameter should be set to the number of separate
drives comprising a RAID 0 stripe or RAID 1 mirror or any combination.
For RAID 5, it should be set to the number of drives excluding the
parity drive. However, the optimal value varies based on the
effectiveness of the RAID controller or software implementation, and
may require some experimentation."

3. "For more exotic systems, such as memory-based storage or a RAID
array which is limited by bus bandwidth, the correct value might be
the number of paths available instead; again, experimentation is
recommended."

4. Insert comma after "However" in third sentence. Replace last
sentence with: "On these operating systems, setting
effective_io_concurrency to a value greater than 1 will incur some CPU
overhead without improving perforamance."

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Tolley 2008-11-19 05:17:24 Re: Patch Review Complete: Multi-Batch Hash Join Improvements
Previous Message Robert Haas 2008-11-19 03:55:42 Re: Updated posix fadvise patch v19