From: | "Robert Haas" <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Ryan Bradetich" <rbradetich(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fwd: [Patch Review] TRUNCATE Permission |
Date: | 2008-09-08 01:36:40 |
Message-ID: | 603c8f070809071836w15cbacf6q314cdf78cddb4c00@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Applied with really pretty minor revisions --- this was a nice clean
> patch. Changes I can recall making:
Woo-hoo, my first patch. Thanks for the cleanup.
...Robert
> * You missed one or two documentation references to DELETE privilege.
>
> * You modified the privileges test to create another userid, but forgot
> to clean up afterwards.
>
> * LOCK TABLE requires UPDATE or DELETE privilege for locks stronger
> than AccessShareLock. I thought it would be inconsistent to not allow
> TRUNCATE to satisfy this requirement too.
>
> * Many of the information_schema views require some privilege on a table
> to show details about the table. Again, it seemed inconsistent to not
> allow TRUNCATE privilege to satisfy this requirement.
>
> * A couple of the information_schema views show available privileges on
> tables by name. It's a bit dubious whether we should show TRUNCATE in
> them, since there is no such privilege bit in the SQL standard, but
> after some reflection I concluded that functionality trumps a narrow
> reading of the spec here. We can revisit that if anyone wants to argue
> for the other way, though.
>
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-09-08 02:21:49 | Re: Move src/tools/backend/ to wiki |
Previous Message | Tom Lane | 2008-09-08 00:54:51 | Re: Fwd: [Patch Review] TRUNCATE Permission |