Re: FullTransactionId changes are causing portability issues

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: FullTransactionId changes are causing portability issues
Date: 2019-05-22 14:48:08
Message-ID: 6039.1558536488@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: buildfarm-members pgsql-hackers

I wrote:
> Our Solaris packager reports that 12beta1 is failing to build for him
> on some Solaris variants:

>> The link failure is:
>> ---
>> Undefined first referenced
>> symbol in file
>> ReadNextFullTransactionId pg_checksums.o
>> ld: fatal: symbol referencing errors. No output written to pg_checksums
>> ---

On looking closer, the fix is simple and matches what we've done
elsewhere: transam.h needs to have "#ifndef FRONTEND" to protect
its static inline function from being compiled into frontend code.

So the disturbing thing here is that we no longer have any active
buildfarm members that can build HEAD but have the won't-elide-
unused-static-functions problem. Clearly we'd better close that
gap somehow ... anyone have an idea about how to test it better?

regards, tom lane

In response to

Responses

Browse buildfarm-members by date

  From Date Subject
Next Message Tom Lane 2019-05-22 19:55:50 Re: FullTransactionId changes are causing portability issues
Previous Message Tom Lane 2019-05-22 13:56:07 FullTransactionId changes are causing portability issues

Browse pgsql-hackers by date

  From Date Subject
Next Message Robbie Harwood 2019-05-22 14:55:18 Re: PostgreSQL 12 Beta 1 press release draft
Previous Message Peter Eisentraut 2019-05-22 14:40:28 Re: "long" type is not appropriate for counting tuples