| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: remove ATTRIBUTE_FIXED_PART_SIZE |
| Date: | 2018-08-21 15:38:55 |
| Message-ID: | 601c8f64-6be6-f31a-688a-6720b56abf55@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/08/2018 15:14, Tom Lane wrote:
> I agree this is all moot as long as there's no pad bytes. What I'm
> trying to figure out is if we need to put in place some provisions
> to prevent there from being pad bytes at the end of any catalog struct.
> According to what Andres is saying, it seems like we do (at least for
> ones with varlena fields).
Yes, I think there could be a problem. I took a brief look through the
catalogs, and while there are plenty of catalogs with trailing padding,
finding that in combination with trailing varlena fields that might
legitimately be all null in practice might require a closer look.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-08-21 15:56:16 | Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Previous Message | Andres Freund | 2018-08-21 15:24:44 | Re: ALTER TABLE on system catalogs |