Re: contrib/tablefunc bugfix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: contrib/tablefunc bugfix
Date: 2003-05-15 05:10:20
Message-ID: 6018.1052975420@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Still getting a number of ecpg related warnings on compile, but I assume
> we're not worried too much about those as of yet.

Me too ... I've been starting to think about ragging on Michael about
those. For starters, C files appearing in src/interfaces ought to
include "postgres_fe.h", rather than a random selection of system
headers. Several of the warnings I'm getting would go away if
ecpg/pgtypeslib/ were following that basic portability practice.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Gerhard Häring 2003-05-15 08:28:00 Re: pygresql build/install problems: use setup.py?
Previous Message Joe Conway 2003-05-15 04:58:02 Re: contrib/tablefunc bugfix