From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Jan Urbański <wulczer(at)wulczer(dot)org>, Greg Smith <greg(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: splitting plpython into smaller parts |
Date: | 2011-12-15 15:30:13 |
Message-ID: | 6015.1323963013@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Peter Eisentraut's message of jue dic 15 12:00:13 -0300 2011:
>> How to people feel about naming the files (as proposed)
>>
>> ! OBJS = plpython.o plpython_io.o plpython_procedure.o plpython_exec.o \
>> ! plpython_plpy.o plpython_spi.o plpython_result.o plpython_cursor.o \
>> ! plpython_plan.o plpython_subtransaction.o plpython_functions.o \
>> ! plpython_elog.o
>>
>> vs. say
>>
>> ! OBJS = main.o io.o procedure.o exec.o plpy.o spi.o result.o cursor.o \
>> ! plan.o subtransaction.o functions.o elog.o
>>
>> ?
> I find the extra prefix unnecessary and ugly; if we had to had a
> prefix, I'd choose a shorter one (maybe "py" instead of "plpython_").
+1 for a prefix, mainly because the shorter names duplicate some
names already in use elsewhere in our tree. But I agree with Alvaro
that "py" would be sufficient.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-12-15 15:34:55 | Re: Moving more work outside WALInsertLock |
Previous Message | Alvaro Herrera | 2011-12-15 15:16:29 | Re: splitting plpython into smaller parts |