| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing llvm_leave_fatal_on_oom() call |
| Date: | 2023-07-05 10:34:38 |
| Message-ID: | 5f992a13-9fa9-1d53-d272-7527dd96c675@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/07/2023 19:33, Daniel Gustafsson wrote:
>> On 21 Feb 2023, at 15:50, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>>
>> llvm_release_context() calls llvm_enter_fatal_on_oom(), but it never calls llvm_leave_fatal_on_oom(). Isn't that a clear leak?
>
> Not sure how much of a leak it is since IIUC LLVM just stores a function
> pointer to our error handler, but I can't see a reason not clean it up here.
> The attached fix LGTM and passes make check with jit_above_cost set to zero.
Pushed to all live branches, thanks for the review!
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-07-05 10:36:31 | Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table. |
| Previous Message | Tomas Vondra | 2023-07-05 10:16:48 | Re: brininsert optimization opportunity |