From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, jian(dot)universality(at)gmail(dot)com, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add new error_action COPY ON_ERROR "log" |
Date: | 2024-02-20 08:22:58 |
Message-ID: | 5f5c3e316d7f24e31d8983f32be0f2bc@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2024-02-17 15:00, Bharath Rupireddy wrote:
> On Fri, Feb 16, 2024 at 8:17 PM torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
> wrote:
>>
>> I may be wrong since I seldom do data loading tasks, but I greed with
>> you.
>>
>> I also a little concerned about the case where there are many
>> malformed
>> data and it causes lots of messages, but the information is usually
>> valuable and if users don't need it, they can suppress it by changing
>> client_min_messages.
>>
>> Currently both summary of failures and individual information is
>> logged
>> in NOTICE level.
>> If we should assume that there are cases where only summary
>> information
>> is required, it'd be useful to set lower log level, i.e. LOG to the
>> individual information.
>
> How about we emit the summary at INFO level and individual information
> at NOTICE level? With this, the summary is given a different priority
> than the individual info. With SET client_min_messages = WARNING; one
> can still get the summary but not the individual info. Also, to get
> all of these into server log, one can SET log_min_messages = INFO; or
> SET log_min_messages = NOTICE;.
>
> Thoughts?
It looks good to me.
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-02-20 08:43:41 | Re: About a recently-added message |
Previous Message | Dilip Kumar | 2024-02-20 08:02:36 | Re: logical decoding and replication of sequences, take 2 |