| From: | Florin Irion <irionr(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_create_logical_replication_slot argument incongruency |
| Date: | 2022-09-20 06:41:56 |
| Message-ID: | 5eeabd10-1aff-ea61-f92d-9fa0d9a7e207@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/09/22 03:33, Michael Paquier wrote:
> On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
>> This was introduced in commit 19890a06.
>>
>> IMHO we should use the documented argument name `two_phase` and change the
>> function to accept it.
>>
>> What do you think?
>
> 19890a0 is included in REL_14_STABLE, and changing an argument name is
> not acceptable in a stable branch as it would imply a catversion
> bump. Let's change the docs so as we document the parameter as
> "twophase", instead.
> --
> Michael
I understand.
OK, patch only for the docs attached.
Cheers,
Florin
www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| two_phase_slot_v2.patch | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-09-20 06:50:39 | Re: Add common function ReplicationOriginName. |
| Previous Message | Amit Langote | 2022-09-20 06:40:55 | Re: missing indexes in indexlist with partitioned tables |