Re: Schema variables - new implementation for Postgres 15

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, dean(dot)a(dot)rasheed(at)gmail(dot)com, er(at)xs4all(dot)nl, joel(at)compiler(dot)org, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Schema variables - new implementation for Postgres 15
Date: 2023-03-29 10:17:29
Message-ID: 5e48a433-0b56-48a0-32a0-fb2e8b16ebce@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24.03.23 08:04, Pavel Stehule wrote:
> Maybe I can divide the  patch 0002-session-variables to three sections -
> related to memory management, planning and execution?

Personally, I find the existing split not helpful. There is no value
(to me) in putting code, documentation, and tests in three separate
patches. This is in fact counter-helpful (to me). Things like the
DISCARD command (0005) and the error messages changes (0009) can be
separate patches, but most of the rest should probably be a single patch.

I know you have been asked earlier in the thread to provide smaller
patches, so don't change it just for me, but this is my opinion.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-03-29 10:27:58 Re: SQL/JSON revisited
Previous Message stephane tachoires 2023-03-29 10:13:37 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands