| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [19] CREATE SUBSCRIPTION ... SERVER |
| Date: | 2026-01-11 04:55:01 |
| Message-ID: | 5dfe845221db2e7d38fc7c2a18a4ba5ea29cdfc0.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2025-12-26 at 13:52 -0800, Jeff Davis wrote:
> On Wed, 2025-04-02 at 17:58 +0530, Shlok Kyal wrote:
> > I reviewed the patch and I have a comment:
> >
> > If version is >=18, the query will have 'suboriginremotelsn',
> > 'subenabled', 'subfailover' twice.
>
> Thank you. Fixed and rebased.
Attached new version with significant changes:
- fixed several issues (including some improper merges in the last
rebase)
- refactored to share code between postgres_fdw_connection() and
connect_pg_server()
- added docs in postgres_fdw
- added tests in core
- bumped postgres_fdw version to 1.3
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v16-0001-CREATE-SUBSCRIPTION-.-SERVER.patch | text/x-patch | 62.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-11 04:58:45 | Re: Correct comment wording in extension.c |
| Previous Message | zengman | 2026-01-11 04:24:22 | Re: [PATCH] Fix minor issues in astreamer_zstd.c |