From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
Subject: | Re: PATCH: Exclude additional directories in pg_basebackup |
Date: | 2016-09-27 13:54:28 |
Message-ID: | 5def3408-e081-666a-8c24-e80245dd8041@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 9/26/16 2:36 AM, Michael Paquier wrote:
>
> Just a nit:
> <para>
> - <filename>postmaster.pid</>
> + <filename>postmaster.pid</> and <filename>postmaster.opts</>
> </para>
> Having one <para> block for each file would be better.
I grouped these because they are related and because there are now other
bullets where multiple files/dirs are listed.
Are you proposing to also breakup <filename>pg_replslot</>,
<filename>pg_dynshmem</>, <filename>pg_stat_tmp</>,
<filename>pg_notify</>, <filename>pg_serial</>,
<filename>pg_snapshots</>, and <filename>pg_subtrans</>?
Also <filename>backup_label</> and <filename>tablespace_map</>?
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-09-27 13:58:59 | Re: Showing parallel status in \df+ |
Previous Message | Tom Lane | 2016-09-27 13:49:20 | Re: Make flex/bison checks stricter in Git trees |