| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Paul Guo <pguo(at)pivotal(dot)io> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jimmy Yih <jyih(at)pivotal(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Subject: | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |
| Date: | 2019-09-25 19:26:54 |
| Message-ID: | 5d8f802d0cc1871ac4bd9450ba98ce8d0626bb58.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2019-09-25 at 14:48 -0300, Alvaro Herrera wrote:
> Another thing in 0002 is that you're adding a "-R" switch to
> pg_rewind, but we have another patch in the commitfest using the same
> switch for a different purpose. Maybe you guys need to get to an
> agreement over who uses the letter :-) Also, it would be super
> helpful if you review Alexey's patch:
> https://commitfest.postgresql.org/24/1849/
I believe that -R should be reserved for creating recovery.conf,
similar to pg_basebackup.
Everything else would be confusing.
I've been missing pg_rewind -R!
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-09-25 19:54:35 | Re: Control your disk usage in PG: Introduction to Disk Quota Extension |
| Previous Message | Peter Geoghegan | 2019-09-25 19:14:08 | Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index. |