| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fix more casting away of qualifiers |
| Date: | 2026-08-25 12:14:44 |
| Message-ID: | 5d20850c-a2a1-45c8-83ed-7efb0303a90a@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25.08.26 10:52, Daniel Gustafsson wrote:
>> On 25 Aug 2026, at 10:42, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
>> I have committed these patches except the one above.
>
> BF member sifaka complains due to (it seems like) macOS bundling readline 3.0
> in the base OS. Maybe we need a configure/meson check for this?
>
> tab-complete.in.c:1525:19: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> 1525 | rl_readline_name = pset.progname;
> | ^ ~~~~~~~~~~~~~
> 1 error generated.
Ok, thanks, I'm going to revert it. I was anticipating something like
this, but at least now we know for sure.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2026-08-25 12:18:33 | Re: right() returns the whole string for the most negative n |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-08-25 12:09:42 | RE: Assertion failure in GetSubscriptionRelations() with concurrent DROP TABLE |