From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru> |
Cc: | Shubham Barai <shubhambaraiss(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
Subject: | Re: [HACKERS] GSoC 2017: weekly progress reports (week 6) |
Date: | 2018-04-28 16:23:11 |
Message-ID: | 5ce68798-cbbb-a47f-96f0-4f19a6c6868c@sigaev.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
> I took a stab at fixing those issues, as well as the bug when fastupdate is
> turned on concurrently. Does the attached patch look sane to you?
That's look sane, and I believe it should be applied but I see some issue in
your patch:
I don't very happy with rootBuffer added everywhere. ginInsertItemPointers() and
ginPrepareDataScan() now take both args, rootBlkno and rootBuffer, second
could be invalid. As I can see, you did it to call
CheckForSerializableConflictIn() in ginEntryInsert(). Seems, it could be
reverted and CheckForSerializableConflictIn() should be added to
ginFindLeafPage() with searchMode = false.
Rebased patch is attached.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
Attachment | Content-Type | Size |
---|---|---|
0001-Re-think-predicate-locking-on-GIN-indexes-v2.patch | text/x-patch | 33.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-04-28 16:32:04 | Re: Postgres, fsync, and OSs (specifically linux) |
Previous Message | Tom Lane | 2018-04-28 16:21:03 | Re: Verbosity of genbki.pl |
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2018-04-28 17:31:18 | Re: [HACKERS] GSoC 2017: weekly progress reports (week 6) |
Previous Message | David M. Kaplan | 2018-04-27 10:19:26 | Wiki editor request |