| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Florin Irion <irionr(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, pgsql-hackers(at)postgresql(dot)org, laurenz(dot)albe(at)cybertec(dot)at |
| Subject: | Re: Reserve prefixes for loaded libraries proposal |
| Date: | 2021-12-01 14:22:39 |
| Message-ID: | 5cae3907-e396-c72f-e69a-1d2950585755@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.10.21 14:03, Florin Irion wrote:
> I adjusted a bit the code and configured my mail client to
> send patch attachments appropiately(hopefully). :)
>
> So here is my second version.
Committed.
I made two notable changes: I renamed the function, since it looked
like EmitWarningsOnPlaceholders() but was doing something not analogous.
Also, you had in your function
strncmp(varName, var->name, varLen)
probably copied from EmitWarningsOnPlaceholders(), but unlike there, we
want to compare the whole string here, and this would potentially do
something wrong if there were a GUC setting that was a substring of the
name of another one.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-12-01 14:26:38 | Re: SQL/JSON: functions |
| Previous Message | Matthias van de Meent | 2021-12-01 14:11:54 | Re: [PATCH] Partial foreign key updates in referential integrity triggers |