| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix compiler warning |
| Date: | 2019-09-05 14:05:40 |
| Message-ID: | 5c927b9b-0000-ce62-6a18-1e0ed825c5c4@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2019-09-02 10:03, Michael Paquier wrote:
> On Mon, Sep 02, 2019 at 07:54:16AM +0200, Peter Eisentraut wrote:
>> Is this code new in PG12? Doesn't look like it to me.
>
> Well, 12 has not been released yet, which is the point I am trying to
> make. The code was introduced in 10, and as the fix is trivial it
> seems to me that it could be back-patched. For example even recently
> you back-patched f02bd63 in the same category. If you don't think
> that's worth it, that's fine for me as well.
That patch made sure the whole tree compiles without warning.
The tree currently does not compile without warnings on Windows (for
me), so it doesn't seem worth fixing warnings piece by piece in the
backbranches.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-09-05 14:15:24 | Re: pgsql: Fix compiler warning |
| Previous Message | Peter Eisentraut | 2019-09-05 06:37:53 | pgsql: Use explicit_bzero |