From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>
Date: 2021-09-13 09:41:56
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 9/2/21 8:52 PM, Andrew Dunstan wrote:
> On 7/22/21 3:49 AM, Erik Rijkers wrote:
>> Hi
>> Here are the 4 unchanged patches from v49, to which I added 2 patches,
>> which are small changes wrt usage of  'JsonIs'  versus  'IsJson'.
>> That should make the cfbot green again.
> Apparently not, but I have rebased this and the sql/json function patch
> set and incorporated your changes in both.

> [0001-SQL-JSON-functions-v50.patch]
> [0002-JSON_TABLE-v50.patch]
> [0003-JSON_TABLE-PLAN-DEFAULT-clause-v50.patch]
> [0004-JSON_TABLE-PLAN-clause-v50.patch]

These don't apply any more, could you have a look?


Erik Rijkers

(output from gcc 11.2:)

parse_jsontable.c: In function ‘makeStringConst’:
parse_jsontable.c:57:15: error: ‘union ValUnion’ has no member named ‘type’
57 | n->val.type = T_String;
| ^
parse_jsontable.c:58:16: error: ‘union ValUnion’ has no member named
‘val’; did you mean ‘ival’?
58 | n->val.val.str = str;
| ^~~
| ival
parse_jsontable.c: In function ‘transformJsonTable’:
parse_jsontable.c:714:61: error: ‘union ValUnion’ has no member named ‘type’
714 | castNode(A_Const,
jt->common->pathspec)->val.type != T_String)
| ^
parse_jsontable.c:721:65: error: ‘union ValUnion’ has no member named
‘val’; did you mean ‘ival’?
721 | rootPath = castNode(A_Const,
| ^~~
make[3]: *** [parse_jsontable.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [parser-recursive] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [all-backend-recurse] Error 2
make: *** [all-src-recurse] Error 2
../../../src/ recipe for target 'parse_jsontable.o'
failed recipe for target 'parser-recursive' failed
Makefile:42: recipe for target 'all-backend-recurse' failed
GNUmakefile:11: recipe for target 'all-src-recurse' failed

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Ladhe 2021-09-13 10:02:45 Re: refactoring basebackup.c
Previous Message Greg Nancarrow 2021-09-13 09:06:06 Re: Skipping logical replication transactions on subscriber side