| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Get rid of the dedicated latch for signaling the startup process |
| Date: | 2020-11-04 10:27:53 |
| Message-ID: | 5c1f8a85-747c-7bf9-241e-dd467d8a3586@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 04/11/2020 09:44, Fujii Masao wrote:
> Get rid of the dedicated latch for signaling the startup process.
>
> This commit gets rid of the dedicated latch for signaling the startup
> process in favor of using its procLatch, since that comports better
> with possible generic signal handlers using that latch.
>
> Commit 1e53fe0e70 changed background processes so that they use standard
> SIGHUP handler. Like that, this commit also makes the startup process use
> standard SIGHUP handler to simplify the code.
This seems to have made buildfarm member 'elver' to segfault. I've got a
hunch that setting recoveryWakeupLatch to NULL, when WakeupRecovery()
doesn't check for NULL, is not OK. It's surprising that we're only
seeing this on 'elver', though.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-11-04 11:20:09 | Re: pgsql: Get rid of the dedicated latch for signaling the startup process |
| Previous Message | Heikki Linnakangas | 2020-11-04 09:22:56 | pgsql: pg_rewind: Replace the hybrid list+array data structure with sim |