Re: [PATCH] Add native windows on arm64 support

From: Niyas Sait <niyas(dot)sait(at)linaro(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add native windows on arm64 support
Date: 2022-12-02 09:37:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 02/12/2022 05:02, Michael Paquier wrote:
> Thanks for the updated version. I have been looking at it closely and
> it looks like it should be able to do the job (no arm64 machine for
> Windows here, sigh).
> I have one tiny comment about this part:
> Shouldn't we only enable this flag when we are under aarch64?
> Similarly, I don't think that it is a good idea to switch on
> USE_SSE42_CRC32C_WITH_RUNTIME_CHECK all the time. We should only set
> it when building under x86 and x86_64.

Ok, I will fix ARM64 specific one in the next revision.


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Niyas Sait 2022-12-02 09:50:20 Re: [PATCH] Add native windows on arm64 support
Previous Message Drouvot, Bertrand 2022-12-02 09:32:23 Re: Minimal logical decoding on standbys