| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | jesper(dot)pedersen(at)redhat(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-11-07 15:27:23 |
| Message-ID: | 5a812c25-fc4d-446b-636a-b2328709df8e@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/7/18 10:05 AM, Jesper Pedersen wrote:
> Hi Tom,
>
> On 11/7/18 9:30 AM, Tom Lane wrote:
>> I'm confused by this. Surely the pwrite-based code is writing
>> exactly the
>> same data as before. Do we have to conclude that valgrind is
>> complaining
>> about passing uninitialized data to pwrite() when it did not complain
>> about exactly the same thing for write()?
>>
>> [ looks ... ] No, what we have to conclude is that the write-related
>> suppressions in src/tools/valgrind.supp need to be replaced or augmented
>> with pwrite-related ones.
>>
>
> The attached patch fixes this for me.
>
> Unfortunately pwrite* doesn't work for the pwrite64(buf) line.
>
>
Works for me. If there's no objection I will commit this.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Raiskup | 2018-11-07 15:27:46 | Re: plruby: rb_iterate symbol clash with libruby.so |
| Previous Message | Dmitry Dolgov | 2018-11-07 15:26:01 | Re: [HACKERS] [PATCH] Generic type subscripting |