| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: pg_combinebackup fails on file named INCREMENTAL.* |
| Date: | 2024-04-17 23:56:02 |
| Message-ID: | 5a7817da-6349-4653-8056-470300b6e512@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/18/24 00:14, Robert Haas wrote:
> On Tue, Apr 16, 2024 at 9:25 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Apr 15, 2024 at 10:12 PM David Steele <david(at)pgmasters(dot)net> wrote:
>>> Anyway, I think it should be fixed or documented as a caveat since it
>>> causes a hard failure on restore.
>>
>> Alright, I'll look into this.
>
> Here's a patch.
Thanks! I've tested this and it works as advertised.
Ideally I'd want an error on backup if there is a similar file in any
data directories that would cause an error on combine, but I admit that
it is vanishingly rare for users to put files anywhere but the root of
PGDATA, so this approach seems OK to me.
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-04-18 00:31:05 | Re: Cannot find a working 64-bit integer type on Illumos |
| Previous Message | David Steele | 2024-04-17 23:09:37 | Re: pg_combinebackup does not detect missing files |