Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected

On Thu, 14 Jul 2011 15:15:33 +0300, Peter Eisentraut wrote:
> On sön, 2011-07-10 at 11:40 -0700, Josh Berkus wrote:
>> Hackers,
>>
>> >> B. 6. Current behaviour _is intended_ (there is "if" to check
>> node type) and _"natural"_. In this particular case user ask for text
>> content of some node, and this content is actually "<".
>> >
>> > I don't buy that. The check for the node type is there because
>> > two different libxml functions are used to convert nodes to
>> > strings. The if has absolutely *zero* to do with escaping, expect
>> > for that missing escape_xml() call in the "else" case.
>> >
>> > Secondly, there is little point in having an type XML if we
>> > don't actually ensure that values of that type can only contain
>> > well-formed XML.
>>
>> Can anyone else weigh in on this? Peter?
>
> Looks like a good change to me.
I'll bump it in few hours, as I can't recall password from keyring. Now
I have hands clean and it's not my business to care about this.

Best regards.
Radek.