| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Florian Pflug <fgp(at)phlo(dot)org>, Radosław Smogura <rsmogura(at)softperience(dot)eu> |
| Subject: | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |
| Date: | 2011-07-14 12:15:33 |
| Message-ID: | 1310645733.16381.3.camel@fsopti579.F-Secure.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On sön, 2011-07-10 at 11:40 -0700, Josh Berkus wrote:
> Hackers,
>
> >> B. 6. Current behaviour _is intended_ (there is "if" to check node type) and _"natural"_. In this particular case user ask for text content of some node, and this content is actually "<".
> >
> > I don't buy that. The check for the node type is there because
> > two different libxml functions are used to convert nodes to
> > strings. The if has absolutely *zero* to do with escaping, expect
> > for that missing escape_xml() call in the "else" case.
> >
> > Secondly, there is little point in having an type XML if we
> > don't actually ensure that values of that type can only contain
> > well-formed XML.
>
> Can anyone else weigh in on this? Peter?
Looks like a good change to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Radosław Smogura | 2011-07-14 12:52:33 | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |
| Previous Message | Peter Eisentraut | 2011-07-14 12:15:15 | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |