Re: Patch for yum.js

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Devrim Gündüz <devrim(at)gunduz(dot)org>, pgsql-www <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Patch for yum.js
Date: 2025-06-02 18:11:24
Message-ID: 5a1af6d7-302a-4eeb-a1a0-324c4a87cabb@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 6/2/25 12:59 PM, Devrim Gündüz wrote:
>
> Hi,
>
> Attached is a patch for yum.js which is supposed to do the following:
>
> * Remove mention of Oracle Linux. We don't test and/or support it.
> * Remove RHEL 7 specific code.
>
> I am not a js expert, so wanted to get a review before committing it.
>
> Thanks!

Here's an untested modification of the patch; a couple of changes:

1. It seems like "get_installer" now should always return "dnf" (we may
need to check how it's being called, which I didn't do, since now this
function doesn't have any logic).

2. For "uses_systemd" I used a shorthand given we're just checking to
see if the platform starts with "EL-". This also will guarantee it
returns true or false.

I'm unsure if this captures the intent what you want, but wanted to
propose it.

Thanks,

Jonathan

Attachment Content-Type Size
pgweb-download-js-v2.patch text/plain 1.2 KB

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Adrian Rangel 2025-06-13 05:59:04 Wiki editor request
Previous Message Devrim Gündüz 2025-06-02 16:59:34 Patch for yum.js