| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Paul Kim <mok03127(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum |
| Date: | 2026-07-27 06:55:51 |
| Message-ID: | 5EE46627-6B9A-4967-B009-7693CB52482F@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 23 Jul 2026, at 00:28, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Mon, Jul 20, 2026 at 10:10 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>>
>>> On 20 Jul 2026, at 16:59, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>>>
>>> We're holding cleanup lock on posting tree root while
>>> ginScanPostingTreeToDelete(), not ginVacuumPostingTreeLeaves(). So, I
>>> think yes, vacuum_delay_point() was deleted unintentionally.
>>
>> Yup, my recollection was wrong. ginVacuumPostingTreeLeaves() seems fine for a
>> delay point.
>
> Please, check the patch attached.
I'm slightly against mentioning corruption in the commit message for two reasons:
1. With corruption any effect is possible
2. We are not dealing with corruption here, fortunately
Besides this patch LGTM. Thanks!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandre Felipe | 2026-07-27 07:00:34 | Re: SLOPE - Planner optimizations on monotonic expressions. |
| Previous Message | Jakub Wartak | 2026-07-27 06:47:47 | Re: log_postmaster_stats |