Re: [PATCH] Accept IP addresses in server certificate SANs

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "horikyota(dot)ntt(at)gmail(dot)com" <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Accept IP addresses in server certificate SANs
Date: 2022-03-28 09:17:25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 28 Mar 2022, at 00:44, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> I'll take a look at fixing up the test in this patch tomorrow.

Fixing up the switch_server_cert() calls and using default_ssl_connstr makes
the test pass for me. The required fixes are in the supplied 0004 diff, I kept
them separate to allow the original author to incorporate them without having
to dig them out to see what changed (named to match the git format-patch output
since I think the CFBot just applies the patches in alphabetical order).

Daniel Gustafsson

Attachment Content-Type Size
v10-0001-Move-inet_net_pton-to-src-port.patch application/octet-stream 4.6 KB
v10-0003-squash-libpq-allow-IP-address-SANs-in-server-cer.patch application/octet-stream 5.1 KB
v10-0003-squash-libpq-allow-IP-address-SANs-in-server-cer-1.patch application/octet-stream 2.6 KB
v10-0004-fix-tests.diff application/octet-stream 2.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema 2022-03-28 09:28:19 Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Previous Message Julien Rouhaud 2022-03-28 08:33:30 Re: Allow file inclusion in pg_hba and pg_ident files