The two "XML Fixes" patches still in need of review

From: Chapman Flack <chap(at)anastigmatix(dot)net>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Markus Winand <markus(dot)winand(at)winand(dot)at>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Subject: The two "XML Fixes" patches still in need of review
Date: 2019-03-08 05:08:16
Message-ID: 5C81F8C0.6090901@anastigmatix.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Alvaro has committed two of the patches in this CF entry[1], but the
remaining two have yet to attract review.

This message contains only those two, just as before[2] except rebased
over Alvaro's commits of the others.

<confession>
There are two new changes. The <ulink>s added in the -docfix patch now
have link text, as allowed according to b060e6c, and the -content patch
now updates the definition of the 'content' type in datatypes.sgml,
which I had overlooked before.
</confession>

xml-functions-type-docfix-3.patch adjusts the documentation of the XML type
and related functions to present some behavior and limitations more clearly.

xml-content-2006-2.patch changes the behavior of xmlparse and the
text-to-xml cast to allow any XML 'document' (including one with a DTD)
to be parsed as 'content', where the former behavior was to fail in that
case. This is the same as changing the definition of XML 'content' from
that of SQL:2003 to that of SQL:2006 and later. The later definition is
preferable, because it eliminates a case that can fail in, e.g., pg_restore
(which problem has been reported in the field).

The patches apply in that order (because the -docfix one adds language
describing the current 'content' behavior, then the -content one changes
the behavior, and the language to match it).

Regards,
-Chap

[1] https://commitfest.postgresql.org/22/1872/
[2]
https://www.postgresql.org/message-id/3e8eab9e-7289-6c23-5e2c-153cccea2257@anastigmatix.net

Attachment Content-Type Size
xml-functions-type-docfix-3.patch text/x-patch 30.2 KB
xml-content-2006-2.patch text/x-patch 17.3 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2019-03-08 05:10:27 Re: New vacuum option to do only freezing
Previous Message Kyotaro HORIGUCHI 2019-03-08 04:52:36 Re: Psql patch to show access methods info