| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: de-deduplicate code in DML execution hooks in postgres_fdw |
| Date: | 2019-01-17 05:44:25 |
| Message-ID: | 5C401639.7070408@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2019/01/16 20:30), Etsuro Fujita wrote:
> (2019/01/16 15:54), Michael Paquier wrote:
>> On Wed, Jan 16, 2019 at 02:59:15PM +0900, Etsuro Fujita wrote:
>>> If there are no objections, I'll commit that version of the patch.
>>
>> I think that you could use PgFdwModifyState for the second argument of
>> execute_foreign_modify instead of ResultRelInfo.
>
> Yeah, that is another option, but my favorite would be to use
> ResultRelInfo, as in the original patch by Ashutosh, because that makes
> it possible to write postgresExecForeignInsert,
> postgresExecForeignUpdate, and postgresExecForeignDelete as a single line.
>
>> Except of that nit,
>> it looks fine to me, thanks for taking care of it.
>
> Great! Thanks for the review!
Pushed. I left that argument alone. I think we can change it later, if
necessary :).
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-01-17 05:55:39 | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
| Previous Message | Andrew Gierth | 2019-01-17 05:29:59 | Re: Ryu floating point output patch |