| From: | Alban Hertroys <haramrae(at)gmail(dot)com> |
|---|---|
| To: | Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net> |
| Cc: | DAVID ROTH <adaptron(at)comcast(dot)net>, Dominique Devienne <ddevienne(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christophe Pettus <xof(at)thebuild(dot)com>, Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Martijn Tonies (Upscene Productions)" <m(dot)tonies(at)upscene(dot)com>, pgsql-general(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Stored procedure code no longer stored in v14 and v15, changed behaviour |
| Date: | 2022-12-04 17:05:30 |
| Message-ID: | 5AF91A67-52F3-4D55-9402-CD4939027733@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
> On 3 Dec 2022, at 20:55, Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net> wrote:
>
>> You would need to wrap the function creation calls into some automation to generate and store those diffs, comparing it back, etc, but that may be doable. I would also generate new diffs right after major version updates of the database (a before and after of the output of pg_get_functiondef, applied to the stored diff?).
>
> I wonder whether that would tie the sanity check to a particular PG version.
>
> I mean, pg_get_functiondef output being a server runtime artifact it might
> well change between server versions, no ?
I meant to write: “I would also generate new diffs right _before and_ after…”, precisely for that reason. The before patch should get you the last ’sane’ situation to get back to the source code. Next, you can diff that to the newly tokenised version after the upgrade.
It is a bit of a hassle, as you need to remember to do that before an upgrade, but at least you’d have something…
Alban Hertroys
--
If you can't see the forest for the trees,
cut the trees and you'll find there is no forest.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2022-12-04 18:09:47 | Re: Q: error on updating collation version information |
| Previous Message | Karsten Hilbert | 2022-12-04 12:35:22 | Re: Q: error on updating collation version information |