| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor comment update in execPartition.c |
| Date: | 2018-04-25 03:08:47 |
| Message-ID: | 5ADFF13F.9070409@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2018/04/25 11:05), Alvaro Herrera wrote:
> Amit Langote wrote:
>
>>> I think we should remove the words "if not already done" from that
>>> comment because 1) that function is called if the partition wasn't
>>> already initialized and 2) that function assumes that. Attached is a
>>> small patch for removing the words.
>>
>> Thanks, sounds fine. I think those words remain from earlier versions of
>> the patch committed as edd44738bc8 [1], where there used to be a fast-path
>> return if the ResultRelInfo was already non-NULL for the passed in index.
>
> Makes sense -- pushed, thanks both.
Thanks for committing, Alvaro! Thanks for reviewing, Amit!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christophe Pettus | 2018-04-25 05:34:35 | Re: Built-in connection pooling |
| Previous Message | Amit Langote | 2018-04-25 02:19:23 | Re: Oddity in tuple routing for foreign partitions |