Re: amcheck: add index-all-keys-match verification for B-Tree

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Wenbo Lin <linwenbo1994(at)gmail(dot)com>
Subject: Re: amcheck: add index-all-keys-match verification for B-Tree
Date: 2026-07-27 14:12:42
Message-ID: 5AC2156E-AC9B-4D07-AC6C-D5D5AF5DBD35@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jakub, thanks for the next review round! I'll provide thoughtful answers later.
Here's some context:

> On 27 Jul 2026, at 17:15, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> wrote:
>
>> One thing still on my TODO list for a next version: the key
>> comparison relies on bt_normalize_tuple(), and normalization has
>> historically been a rich source of subtle bugs for heapallindexed
>> (TOAST compression differences, and a whole series of follow-up
>> fixes for various datum representations).[..]
>
> It's way outside of my typical area, can You please share some sample pointer or
> link?

e.g. see ab65dfb0fb2, eba775345d2, b1fe8efdf1.
The thing is index key fingerprint might be different under different circumstances.

Thanks!

Best regards, Andrey Borodin.

[0] https://github.com/postgres/postgres/commit/ab65dfb0fb2
[1] https://github.com/postgres/postgres/commit/eba775345d2
[2] https://github.com/postgres/postgres/commit/b1fe8efdf17

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2026-07-27 14:33:22 Re: Unexpected behavior after OOM errors
Previous Message Pavel Stehule 2026-07-27 14:09:45 Re: POC: PLpgSQL FOREACH IN JSON ARRAY